Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kube-prometheus-stack] Add Kustomize for Managing CRDs #3380

Closed
wants to merge 1 commit into from
Closed

[kube-prometheus-stack] Add Kustomize for Managing CRDs #3380

wants to merge 1 commit into from

Conversation

KazW
Copy link

@KazW KazW commented May 16, 2023 •
edited
Loading

This PR simplifies the process of managing CRDs by using Kustomize.

Test command: kubectl apply --server-side -k "https://github.com/KazW/helm-charts/charts/kube-prometheus-stack/crds/?ref=add-kustomize-to-crds"

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@KazW
Add kustomize for CRDs.
b473294 
Signed-off-by: Kaz Walker <[email protected]>
@KazW KazW force-pushed the add-kustomize-to-crds branch from 30dffb2 to b473294 Compare May 16, 2023 05:12
monotek
monotek requested changes May 26, 2023
View reviewed changes
Copy link
Member

@monotek monotek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess deleting the crds would also delete your prometheus instance.

using kustomize is imho also out of scope of this repo.

@KazW
Copy link
Author

KazW commented May 26, 2023

i guess deleting the crds would also delete your proemtehus instance.

using kustomize is imho also out of scope of this repo.

Ok, I was thinking it might be. Do you think a PR like this would be better in the prometheus-operator repo?

@monotek
Copy link
Member

monotek commented May 26, 2023

Not sure...

@GMartinez-Sisti
Copy link
Member

Hi @KazW, #3547 provides a way to manage the CRDs in an easier way.

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monotek monotek monotek requested changes

@andrewgkew andrewgkew Awaiting requested review from andrewgkew andrewgkew is a code owner

@gianrubio gianrubio Awaiting requested review from gianrubio gianrubio is a code owner

@gkarthiks gkarthiks Awaiting requested review from gkarthiks gkarthiks is a code owner

@GMartinez-Sisti GMartinez-Sisti Awaiting requested review from GMartinez-Sisti GMartinez-Sisti is a code owner

@QuentinBisson QuentinBisson Awaiting requested review from QuentinBisson QuentinBisson is a code owner

@scottrigby scottrigby Awaiting requested review from scottrigby scottrigby is a code owner

@Xtigyro Xtigyro Awaiting requested review from Xtigyro Xtigyro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kube-prometheus-stack] Use Kustomize for Managing CRDs
3 participants
@KazW @monotek @GMartinez-Sisti