Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Use Kustomize for Managing CRDs #3379

Closed
KazW opened this issue May 16, 2023 · 3 comments
Closed

[kube-prometheus-stack] Use Kustomize for Managing CRDs #3379

KazW opened this issue May 16, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@KazW
Copy link

KazW commented May 16, 2023

Managing CRDs can be made easier with a Kustomization resource in the chart's crds folder. If Kustomize was used, the CRDs can be updated to the latest or a specific version more easily.

Latest:

kubectl apply --server-side -k https://github.com/prometheus-community/helm-charts/charts/kube-prometheus-stack/crds/

Versioned:

kubectl apply --server-side -k https://github.com/prometheus-community/helm-charts/charts/kube-prometheus-stack/crds/?ref=kube-prometheus-stack-x.y.z

Describe the solution you'd like.

Add a kustomization.yaml file to the crds directory that references the CRD files.

Describe alternatives you've considered.

NONE

Additional context.

This is the approach Traefik uses: https://github.com/traefik/traefik-helm-chart

@KazW KazW added the enhancement New feature or request label May 16, 2023
@KazW KazW changed the title [prometheus-kube-stack] Use Kustomize for Updating CRDs [kube-prometheus-stack] Use Kustomize for Updating CRDs May 16, 2023
@KazW KazW changed the title [kube-prometheus-stack] Use Kustomize for Updating CRDs [kube-prometheus-stack] Use Kustomize for Managing CRDs May 16, 2023
@stale
Copy link

stale bot commented Jun 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@rgarcia6520
Copy link

Placing a kustomization.yaml there will break Fluxv2 installations (an error will be thrown the kustomization can't be created properly), this would be better placed in https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-operator-crds/templates/ chart

@stale stale bot removed the lifecycle/stale label Jul 10, 2023
@GMartinez-Sisti
Copy link
Member

Hi @KazW, #3547 provides a way to manage the CRDs in an easier way.

Closing this. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants