Support React 17 (Fixes #751) #755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #751 |
alexandernst
changed the title
|
Feels like we should just go all in with 17, and not even worry about 16, thoughts? |
|
It doesn't hurt to leave React 16, at least for the moment. Even if 16 and 17 are completely compatible, a lot of projects haven't updated yet their peer dependencies, which means that if you leave only React 17, people will get warnings as the one I added in #751. It won't break anything, but it will show warnings when running "yarn install". |
|
@dylanvorster Is there anything else I should add to this? |
|
Upgraded all the deps, its now in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn run prettyWhat?
Upgrade to React 17
Why?
Because it will provide better support in the long term.
How?
By upgrading all libraries that haven't been upgraded to React 17 (bugging their creators), then updating this library.