Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release new version compatible with React 17 #751

Open
alexandernst opened this issue Oct 22, 2020 · 1 comment
Open

Release new version compatible with React 17 #751

alexandernst opened this issue Oct 22, 2020 · 1 comment

Comments

@alexandernst
Copy link
Contributor

React 17 was just released. There are no breaking changes, but if I try to use it with react-diagrams, I get warnings about missing peer-dependencies (react-diagrams depends on [email protected]).

Can you release a new version making this package compatible with React 17? @dylanvorster
@alexandernst alexandernst mentioned this issue Oct 28, 2020
Closed
5 tasks
@alexandernst
Copy link
Contributor Author

@dylanvorster I bugged devs from several libraries. All of them upgraded their libraries and added React 17 as an optional peer dependency. The only library that is missing is @reach/router, but none of the contributors is replying ( reach/router#429 ).

If you release react-diagrams without waiting for this library to get upgraded, a warning will appear when running yarn install:

warning "@storybook/addon-actions > @storybook/api > @reach/[email protected]" has incorrect peer dependency "[email protected] || 16.x || 16.4.0-alpha.0911da3".

everything will work fine though.

Pavinati pushed a commit to Pavinati/astarte-dashboard that referenced this issue Feb 24, 2021
Downgrade react to 16.14.0
669b8e4 
Downgrade react to 16.14 to maintain compability with react-diagrams.
see projectstorm/react-diagrams#751 for more
details

Signed-off-by: Mattia <[email protected]>
@Pavinati Pavinati mentioned this issue Feb 24, 2021
Merged
Pavinati pushed a commit to Pavinati/astarte-dashboard that referenced this issue Feb 24, 2021
Downgrade react to 16.14.0
ca9e7cc 
Downgrade react to 16.14 to maintain compability with react-diagrams.
see projectstorm/react-diagrams#751 for more
details

Signed-off-by: Mattia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexandernst