Enable compatibility tests on macOS #6857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables all the compatibility tests that are currently doable on macOS, namely, all tests except the ones relying on RocksDB. Compatibility tests with RocksDB fail consistently with SIGSEGV on macOS.
adutra
commented
May 19, 2023
| // Compatibility tests fail, because Windows not supported by testcontainers (logged message) | ||
| if ((Os.isFamily(Os.FAMILY_MAC) || Os.isFamily(Os.FAMILY_WINDOWS)) && System.getenv("CI") != null) { |
There was a problem hiding this comment.
This will have the side-effect of enabling compatibility tests in CI. If they fail for whatever reason, I will re-disable them in CI. As long as I can run them locally it's fine :-)
|
As expected CI has failed, so I just reverted the CI change. Podman usage in the macOS CI jobs needs some serious updates, which I will try to tackle next. |
snazy
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables all the compatibility tests that are currently doable on macOS, namely, all tests except the ones relying on RocksDB.
Compatibility tests with RocksDB fail consistently with SIGSEGV on macOS.