Use nip.io domain in MinioExtension #6856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
commented
May 19, 2023
| format( | ||
| "Disabled on %s, because it doesn't support wildcard localhost FQDNs.", | ||
| OS.current().name())); | ||
| return disabled(format("Disabled on %s", OS.current().name())); |
There was a problem hiding this comment.
TBH I think the extension is also compatible with Windows now, but I can't really guarantee. This is why I simplified the message.
|
Same thing as #6857, CI jobs have failed, so I reverted the CI changes. |
|
The failure in |
This commit also re-enables MinioExtension on macOS since the switch to nip.io fixes the localhost subdomain issue.
snazy
approved these changes
May 19, 2023
snazy
added a commit
to snazy/nessie
that referenced
this pull request
May 24, 2023
nip.io's "magic" DNS names are not always resolvable, or resolvable in every setup. This change first tries to resolve the "magic" nip.io address and falls back to the pre-projectnessie#6856 behavior if the pre-check fails.
snazy
added a commit
to snazy/nessie
that referenced
this pull request
May 24, 2023
nip.io's "magic" DNS names are not always resolvable, or resolvable in every setup. This change first tries to resolve the "magic" nip.io address and falls back to the pre-projectnessie#6856 behavior if the pre-check fails.
snazy
added a commit
to snazy/nessie
that referenced
this pull request
May 24, 2023
nip.io's "magic" DNS names are not always resolvable, or resolvable in every setup. This change first tries to resolve the "magic" nip.io address and falls back to the pre-projectnessie#6856 behavior if the pre-check fails.
snazy
added a commit
that referenced
this pull request
May 24, 2023
nip.io's "magic" DNS names are not always resolvable, or resolvable in every setup. This change first tries to resolve the "magic" nip.io address and falls back to the pre-#6856 behavior if the pre-check fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also re-enables MinioExtension on macOS since the switch to nip.io fixes the localhost subdomain issue.
Note: this will have the side-effect of enabling MinIO tests on CI for macOS. If these fail, I will disable the tests, but for CI only.