Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quarkus ConfigProperties deprecation #1534

Closed
wants to merge 1 commit into from
Closed

Fix Quarkus ConfigProperties deprecation #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...uarkus-server/src/main/java/org/projectnessie/server/config/DynamoVersionStoreConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@
*/
package org.projectnessie.server.config;

import io.quarkus.arc.config.ConfigProperties;
import org.eclipse.microprofile.config.inject.ConfigProperty;
import org.projectnessie.versioned.dynamodb.DynamoStoreConfig;

Copy link
Member

@snazy snazy Jul 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that'll cause a spotless-check error (empty line)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would have been picked up

nessie/pom.xml

Lines 1325 to 1330 in b784d4d

<id>spotless-check</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
but that doesn't seem to be the case

import io.smallrye.config.ConfigMapping;

/** DynamoDB version store configuration. */
@ConfigProperties(prefix = "nessie.version.store.dynamo")
@ConfigMapping(prefix = "nessie.version.store.dynamo")
public interface DynamoVersionStoreConfig {

@ConfigProperty(name = "initialize", defaultValue = "false")
Expand Down
8 changes: 5 additions & 3 deletions .../quarkus-server/src/main/java/org/projectnessie/server/config/JGitVersionStoreConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,15 @@
*/
package org.projectnessie.server.config;

import io.quarkus.arc.config.ConfigProperties;
import io.quarkus.runtime.annotations.RegisterForReflection;
import java.util.Optional;

import org.eclipse.microprofile.config.inject.ConfigProperty;

import io.quarkus.runtime.annotations.RegisterForReflection;
import io.smallrye.config.ConfigMapping;

/** JGit version store configuration. */
@ConfigProperties(prefix = "nessie.version.store.jgit")
@ConfigMapping(prefix = "nessie.version.store.jgit")
public interface JGitVersionStoreConfig {
@RegisterForReflection
public enum JGitStoreType {
Expand Down
5 changes: 3 additions & 2 deletions ...ers/quarkus-server/src/main/java/org/projectnessie/server/config/QuarkusServerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@
*/
package org.projectnessie.server.config;

import io.quarkus.arc.config.ConfigProperties;
import org.eclipse.microprofile.config.inject.ConfigProperty;
import org.projectnessie.services.config.ServerConfig;

import io.smallrye.config.ConfigMapping;

/** Nessie server config for Quarkus. */
@ConfigProperties(prefix = "nessie.server")
@ConfigMapping(prefix = "nessie.server")
public interface QuarkusServerConfig extends ServerConfig {

@ConfigProperty(name = "default-branch", defaultValue = "main")
Expand Down
7 changes: 4 additions & 3 deletions servers/quarkus-server/src/main/java/org/projectnessie/server/config/VersionStoreConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@
*/
package org.projectnessie.server.config;

import io.quarkus.arc.config.ConfigProperties;
import io.quarkus.runtime.annotations.RegisterForReflection;
import org.eclipse.microprofile.config.inject.ConfigProperty;

import io.quarkus.runtime.annotations.RegisterForReflection;
import io.smallrye.config.ConfigMapping;

/** Version store configuration. */
@ConfigProperties(prefix = "nessie.version.store")
@ConfigMapping(prefix = "nessie.version.store")
public interface VersionStoreConfig {

@RegisterForReflection
Expand Down