Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quarkus ConfigProperties deprecation #1534

Closed

Conversation

laurentgo
Copy link
Contributor

@laurentgo laurentgo commented Jul 7, 2021

This change is Reviewable

@@ -15,12 +15,13 @@
*/
package org.projectnessie.server.config;

import io.quarkus.arc.config.ConfigProperties;
import org.eclipse.microprofile.config.inject.ConfigProperty;
import org.projectnessie.versioned.dynamodb.DynamoStoreConfig;

Copy link
Member

@snazy snazy Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that'll cause a spotless-check error (empty line)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would have been picked up

nessie/pom.xml

Lines 1325 to 1330 in b784d4d

<id>spotless-check</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
but that doesn't seem to be the case

@rymurr
Copy link
Contributor

rymurr commented Jul 8, 2021

superceded by #1563

@rymurr rymurr closed this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants