Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Quarkus 2.0.0.Final #1490

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Jun 24, 2021

This change is Reviewable

@nastra nastra requested a review from rymurr June 24, 2021 08:32
@nastra nastra force-pushed the quarkus-2.0.0-upgrade branch 2 times, most recently from 18a71aa to 292a77c Compare June 24, 2021 09:12
rymurr
rymurr previously approved these changes Jun 24, 2021
Copy link
Contributor

@rymurr rymurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run the native tests locally? The quarkus bump may break those.

@nastra
Copy link
Contributor Author

nastra commented Jun 24, 2021

Native tests are currently failing due to quarkusio/quarkus#14904 / JGIT: quarkusio/quarkus#16017, which seems to be already fixed

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #1490 (18cfc8c) into main (07b9d21) will increase coverage by 0.01%.
The diff coverage is 89.69%.

❗ Current head 18cfc8c differs from pull request most recent head 08149f0. Consider uploading reports for the commit 08149f0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1490      +/-   ##
============================================
+ Coverage     78.63%   78.64%   +0.01%     
- Complexity     2077     2080       +3     
============================================
  Files           259      259              
  Lines         12070    12091      +21     
  Branches        969      970       +1     
============================================
+ Hits           9491     9509      +18     
- Misses         2100     2102       +2     
- Partials        479      480       +1     
Flag Coverage Δ
java 78.14% <89.69%> (+0.01%) ⬆️
python 84.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../projectnessie/quarkus/maven/MojoConfigSource.java 0.00% <0.00%> (ø)
.../projectnessie/versioned/dynamodb/DynamoStore.java 83.82% <75.00%> (-0.36%) ⬇️
...g/projectnessie/versioned/impl/InternalBranch.java 73.31% <78.57%> (+0.58%) ⬆️
...ava/org/projectnessie/client/NessieHttpClient.java 75.32% <87.50%> (-0.63%) ⬇️
...rg/projectnessie/versioned/store/TracingStore.java 90.56% <93.02%> (-0.26%) ⬇️
.../java/org/projectnessie/versioned/TracingUtil.java 71.42% <100.00%> (-6.35%) ⬇️
...g/projectnessie/versioned/TracingVersionStore.java 99.13% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b9d21...08149f0. Read the comment docs.

@nastra
Copy link
Contributor Author

nastra commented Jun 24, 2021

@rymurr tests with the native image all pass. I'll push a version with the revert of -Pnative change from pull-request.yaml

@nastra nastra force-pushed the quarkus-2.0.0-upgrade branch from 18cfc8c to 08149f0 Compare June 24, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants