Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readerutil: add ConnReadN function #275

Merged
merged 13 commits into from
Nov 2, 2023
Merged

readerutil: add ConnReadN function #275

merged 13 commits into from
Nov 2, 2023

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Oct 30, 2023 •
edited
Loading

Proposed Changes

  • implemented to handle issues like bug fixes in js , network protocol and flow nuclei#4313
  • ConnReadN reads data from connection and waits for io.EOF instead of early return when data is not available
  • Added set of helper functions to execute functions that return multiple values in/with a context
  • go version bump to 1.21

@tarunKoyalwar tarunKoyalwar self-assigned this Oct 31, 2023
@tarunKoyalwar tarunKoyalwar mentioned this pull request Oct 31, 2023
Merged
dogancanbakir
dogancanbakir approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarunKoyalwar tarunKoyalwar marked this pull request as draft October 31, 2023 16:20
@tarunKoyalwar
Copy link
Member Author

thanks just figured out we need to pass them a context to avoid any infinite hangs . so implementing that will request a review again

@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review October 31, 2023 19:39
@tarunKoyalwar tarunKoyalwar mentioned this pull request Oct 31, 2023
Merged
This was linked to issues Oct 31, 2023
Implement ConnReadN to read data from net.Conn and other network reader's #279
Closed
fix double encoding issue in http url #277
Closed
@ehsandeep ehsandeep merged commit 62487ea into main Nov 2, 2023
7 checks passed
@ehsandeep ehsandeep deleted the readutil-connreadN branch November 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@dogancanbakir dogancanbakir Awaiting requested review from dogancanbakir

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tarunKoyalwar @ehsandeep @dogancanbakir