Call parseUnsafeRelativePath() on non-relative paths. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While attempting to use httpx I found that it was not able to process URLs like "https://127.0.0.1/%25", this is because the base golang url parser will discard those chars as invalid. Fortunately, it seems as if this library has another mechanism that can be called for these specific cases, but unfortunately this function was not being called for non-relative URLs. This attempts to fix that issue but calling parseUnsafeRelativePath when non-relative and only when the unsafe boolean is passed to ParseURL.
Mzack9999
approved these changes
Oct 26, 2023
tarunKoyalwar
added a commit
that referenced
this pull request
Oct 31, 2023
Merged
ehsandeep
pushed a commit
that referenced
this pull request
Nov 2, 2023
* readutil: add ConnReadN function * misc improvements * revert #273 with explaination * introduce: NContext * misc changes * use context / set timeout * bump go -> 1.21 * hide/accept timeout error if we get any data * fix accepted error timeout logic * fix race condition * improved explaination of testcase * include pollerr in IsTimeout()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to use
httpx, I found that it was not able to process URLs likehttps://127.0.0.1/%25; this is because the base golang URL parser will discard those chars as invalid.Fortunately, this library has another mechanism that can be called for these specific cases, but unfortunately this function was not being called for non-relative URLs.
This attempts to fix that issue but calls
parseUnsafeRelativePathwhen non-relative and only when the unsafe boolean is passed to ParseURL.Let me know if there are any issues.