Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pprof utils for performance testing/debugging #266

Merged
merged 2 commits into from
Oct 10, 2023
Merged

add pprof utils for performance testing/debugging #266

merged 2 commits into from
Oct 10, 2023

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Oct 9, 2023 •
edited
Loading

@tarunKoyalwar tarunKoyalwar self-assigned this Oct 9, 2023
@tarunKoyalwar tarunKoyalwar linked an issue Oct 9, 2023 that may be closed by this pull request
Implement pprof-dump ticker #265
Closed
@tarunKoyalwar tarunKoyalwar mentioned this pull request Oct 9, 2023
Closed
4 tasks
Mzack9999
Mzack9999 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Neat type abstraction!

dogancanbakir
dogancanbakir approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarunKoyalwar tarunKoyalwar requested review from Mzack9999 and removed request for Mzack9999 October 10, 2023 08:14
@Mzack9999 Mzack9999 merged commit bbca45a into main Oct 10, 2023
7 checks passed
@Mzack9999 Mzack9999 deleted the issue-265-pprof-utils branch October 10, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogancanbakir dogancanbakir dogancanbakir approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pprof-dump ticker
3 participants
@tarunKoyalwar @Mzack9999 @dogancanbakir