Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional debug + profiling #4212

Closed
wants to merge 2 commits into from
Closed

conditional debug + profiling #4212

wants to merge 2 commits into from

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Oct 2, 2023

Proposed changes

go install -tags debug -v github.com/projectdiscovery/nuclei/v2/cmd/nuclei@verbose-debug

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about implementing a generic logic in the utils package as per projectdiscovery/utils#265 and then using an environment variable to activate the automatic dump, so that we don't need a recompilation and can also take snapshot in combination with arbitrary cli options?
I think something like the following with reasonable defaults (customizable with env variables) might be handy and applied to all the tools:

PPROF=1 nuclei

@tarunKoyalwar
Copy link
Member Author

closing this as we are adding it in utils and will be implicity added to all tools deriving from utils with PPROF as switch
ref: projectdiscovery/utils#266

@tarunKoyalwar tarunKoyalwar deleted the verbose-debug branch October 9, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants