Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -certificate-check and -certificate-verify flags #620

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Add -certificate-check and -certificate-verify flags #620

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
475e9cf
removed unused server
ehsandeep Apr 28, 2023
2dddf7f
Merge branch 'dev'
ehsandeep May 19, 2023
539c2dd
Merge branch 'dev'
ehsandeep Jun 30, 2023
d8254fa
Add -cc and -cv flag (certificate check and verify)
hahwul Aug 5, 2023
488d072
Changed TLS verify logic from flag-based to env-based
hahwul Aug 11, 2023
c63f4a5
env update
ehsandeep Aug 27, 2023
31a0a3f
refactor
Mzack9999 Aug 29, 2023
dbd403a
Merge branch 'dev' into pr/620
Mzack9999 Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pkg/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,25 @@ func New(options *Options) (*Client, error) {
httpclient = retryablehttp.NewClient(opts)
}

// INTERACTSH_TLS_VERIFY enforces TLS (cleartext is a fatal error)
if os.Getenv("INTERACTSH_TLS_VERIFY") == "true" {
t, ok := httpclient.HTTPClient.Transport.(*http.Transport)
if !ok {
return nil, errors.New("could not get http transport:")
}
t.TLSClientConfig.InsecureSkipVerify = false
if stringsutil.HasPrefixI(options.ServerURL, "http://") {
return nil, errors.New("tls enforced - invalid URL with cleartext http")
}
interactshServerURL := options.ServerURL
if !stringsutil.HasPrefixAnyI(interactshServerURL, "https://") {
interactshServerURL = fmt.Sprintf("https://%s", interactshServerURL)
}
if _, err := httpclient.HTTPClient.Get(interactshServerURL); err != nil {
return nil, errorutil.NewWithErr(err).Msgf("certificate verification failed")
}
}

var correlationID, secretKey, token string

if options.SessionInfo != nil {
Expand Down