-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -certificate-check and -certificate-verify flags #620
Add -certificate-check and -certificate-verify flags #620
Conversation
@hahwul Thanks for the PR. I was thinking about making TLS behavior customizable via external variable, for example: TLS_VERIFY=false # default-skip
TLS_VERIFY=true # verify certificate In this way it can be applied to all tools and be more consistent console standard variables like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make use of ENV Var instead of CLI option as mzack suggested.
@ehsandeep @Mzack9999 |
This is a thought that has occurred to me personally. It might be worth considering the creation of distinct ENV variables specific to each tool, with a higher priority than TLS_VERIFY. For instance, something like INTERACTSH_TLS_VERIFY could be used. This approach would allow for tailored behaviors for individual tools, while maintaining a consistent approach to TLS verification. |
Hi projectdiscovery team,
This PR is a continuation of the PR from the this discussion. After discussing it a bit more, I looked into it further and found that interactsh-client consistently uses
InsecureSkipVerify=true
. While this is for usability purposes, some users might still prefer a more secure connection from time to time.https://github.com/projectdiscovery/retryablehttp-go/blob/3431517eac0842ae153b681280dfd6e22261d56b/http.go#L46
The two flags added this time are meant to check certificates and either raise a warning or stop the process, thereby alerting users about certificate issues. I'd appreciate your feedback on this :D