Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for euc-kr charset #510

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Adding support for euc-kr charset #510

merged 1 commit into from
Feb 7, 2022

Conversation

Mzack9999
Copy link
Member

Description

This PR adds support for euc-kr charset

How to reproduce

$ echo https://weekly.chosun.com | go run . -title -timeout 20

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/              v1.1.6-dev

                projectdiscovery.io

Use with caution. You are responsible for your actions.
Developers assume no liability and are not responsible for any misuse or damage.
https://weekly.chosun.com [주간조선 > 주간조선]

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Feb 2, 2022
@Mzack9999 Mzack9999 self-assigned this Feb 2, 2022
@Mzack9999 Mzack9999 linked an issue Feb 2, 2022 that may be closed by this pull request
The software only supports charset="UTF-8" #441
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Feb 2, 2022
@ehsandeep ehsandeep merged commit bb5de05 into dev Feb 7, 2022
@ehsandeep ehsandeep deleted the issue-441-utf8 branch February 7, 2022 08:07
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parrasajad parrasajad parrasajad approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The software only supports charset="UTF-8"
3 participants
@Mzack9999 @ehsandeep @parrasajad