Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The software only supports charset="UTF-8" #441

Closed
pandak1d opened this issue Nov 25, 2021 · 3 comments · Fixed by #510 or #532
Closed

The software only supports charset="UTF-8" #441

pandak1d opened this issue Nov 25, 2021 · 3 comments · Fixed by #510 or #532
Assignees
@Mzack9999
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
v1.2.0

Comments

@pandak1d
Copy link

pandak1d commented Nov 25, 2021 •
edited
Loading

The software only supports charset="UTF-8". If the title of charset="euc-kr" will appear garbled, is there a golang package that can automatically convert the encoding format according to charset, just like the library in python

mychar = chardet.detect(response.content)
response.encoding = mychar['encoding']

image
image
@pandak1d pandak1d added the Type: Enhancement Most issues will probably ask for additions or changes. label Nov 25, 2021
@ehsandeep ehsandeep added the Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix label Dec 1, 2021
@ehsandeep
Copy link
Member 

echo https://www.100yearshop.co.kr/shop/main/index.php | httpx -title -silent -timeout 20
https://www.100yearshop.co.kr/shop/main/index.php []

@pandak1d
Copy link
Author

pandak1d commented Dec 3, 2021 •
edited
Loading

Like this is garbled！！！
image

@ehsandeep ehsandeep added this to the v1.1.5 milestone Dec 19, 2021
@ehsandeep ehsandeep removed this from the v1.1.5 milestone Jan 10, 2022
@pandak1d
Copy link
Author

Why was it removed

@Mzack9999 Mzack9999 self-assigned this Feb 2, 2022
@Mzack9999 Mzack9999 added the Status: In Progress This issue is being worked on, and has someone assigned. label Feb 2, 2022
@Mzack9999 Mzack9999 linked a pull request Feb 2, 2022 that will close this issue
Adding support for euc-kr charset #510
Merged
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Feb 2, 2022
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Feb 7, 2022
@ehsandeep ehsandeep added this to the v1.2.0 milestone Mar 1, 2022
@ehsandeep ehsandeep linked a pull request Mar 1, 2022 that will close this issue
v1.2.0 Release #532
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mzack9999 Mzack9999

Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Adding support for euc-kr charset projectdiscovery/httpx
v1.2.0 Release projectdiscovery/httpx
3 participants
@ehsandeep @Mzack9999 @pandak1d