-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Screenshot support #1097
Conversation
Todo:
|
…overy/httpx into issue-385-screenshot
|
Depends on projectdiscovery/utils#137 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
Q: when using -screenshot
httpx stores response dump to responses
even if -store-response
is not used . Is this expected ?
@tarunKoyalwar yeah I thought it could make sense to also store the response, as while taking screenshot we also retrieve the rendered DOM. What do you think @ehsandeep should we keep things separated? |
we can keep the current behavior as it is since the response information can be used to associate with the screenshot information. |
Description
This PR adds basic support for headless mode by adding two new flags:
-screenshot
enables headless mode to take screenshots-system-chrome
uses the local installed chrome if anyWhen the screenshot flag is used, also the rendered dom is retrieved and added to the json output under
headless_body
. The screenshot image is saved in the store response folder and an index file calledindex_screenshot.txt
is created.Doc - https://github.com/projectdiscovery/httpx/tree/issue-385-screenshot#screenshot