Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screenshot support #385

Closed
Mzack9999 opened this issue Aug 30, 2021 · 3 comments · Fixed by #1097
Closed

Add screenshot support #385

Mzack9999 opened this issue Aug 30, 2021 · 3 comments · Fixed by #1097
Assignees
@Mzack9999
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
httpx v1.3.0

Comments

@Mzack9999
Copy link
Member

Along #384 add support for screenshot capability via -screenshot option
@ehsandeep ehsandeep added the Type: Enhancement Most issues will probably ask for additions or changes. label Aug 30, 2021
@ehsandeep ehsandeep added the Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix label Oct 13, 2021
@forgedhallpass forgedhallpass changed the title [Feature] Add screenshot support Add screenshot support Dec 2, 2021
@ehsandeep ehsandeep added Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. and removed Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix labels Dec 19, 2021
@M09Ic
Copy link
Contributor

M09Ic commented Jan 11, 2022

I think this is a useful feature, before I encountered a similar requirement, I had to use python selenium to solve it

@1mansh0w
Copy link

1mansh0w commented Mar 5, 2022

Any updates on this? I think this feature request is great in terms of efficiency, because otherwise you have to redo all the requests just for taking screenshots.

@forgedhallpass
Copy link
Contributor

@M09Ic @1mansh0w

Currently this ticket is under advisement and would require headless support first. See the referenced issue above.
In the meantime as an alternative, you can use nuclei to achieve the same:

nuclei -u https://nuclei.projectdiscovery.io -id screenshot -headless # creates a file named nuclei.projectdiscovery.io.png

@Mzack9999 Mzack9999 added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Priority: Medium This issue may be useful, and needs some attention. and removed Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Apr 14, 2023
@Mzack9999 Mzack9999 self-assigned this Apr 16, 2023
@Mzack9999 Mzack9999 linked a pull request Apr 16, 2023 that will close this issue
Adding Screenshot support #1097
Merged
@ehsandeep ehsandeep removed the Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. label Apr 17, 2023
@ehsandeep ehsandeep added this to the httpx v1.3.0 milestone Apr 18, 2023
@ehsandeep ehsandeep added the Status: In Progress This issue is being worked on, and has someone assigned. label Apr 18, 2023
@Mzack9999 Mzack9999 removed the Status: In Progress This issue is being worked on, and has someone assigned. label Apr 19, 2023
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mzack9999 Mzack9999

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
httpx v1.3.0
Development

Successfully merging a pull request may close this issue.

Adding Screenshot support projectdiscovery/httpx
5 participants
@ehsandeep @Mzack9999 @forgedhallpass @M09Ic @1mansh0w