Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing v1beta2 version for CRD ConversionReviewVersions #753

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix: missing v1beta2 version for CRD ConversionReviewVersions #753

merged 1 commit into from
Apr 25, 2023

Conversation

MaxFedotov
Copy link
Collaborator

closes #752

@netlify
Copy link

netlify bot commented Apr 20, 2023 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 8e0bcf6
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/64414c9ed0e8950008cd7209

prometherion
prometherion approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, Max!

May I ask you to provide in the issue the downside of this bug to inform the end-users what they're gonna face if not upgrading to the latest version?

That will be gold for the changelog when releasing v0.3.2

@prometherion prometherion merged commit e15773e into projectcapsule:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

Assignees

@prometherion prometherion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing ConversionReviewVersions in updateTenantCustomResourceDefinition function
2 participants
@MaxFedotov @prometherion