Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ConversionReviewVersions in updateTenantCustomResourceDefinition function #752

Closed
MaxFedotov opened this issue Apr 20, 2023 · 0 comments · Fixed by #753
Closed

Missing ConversionReviewVersions in updateTenantCustomResourceDefinition function #752

MaxFedotov opened this issue Apr 20, 2023 · 0 comments · Fixed by #753
Assignees
@MaxFedotov
Labels
bug Something isn't working
Milestone
v0.3.2

Comments

@MaxFedotov
Copy link
Collaborator

Bug description

In helm chart both tenant CRD
https://github.com/clastix/capsule/blob/953cfdc172dd1dd93646dd8609cda61071c8528a/charts/capsule/crds/tenant-crd.yaml#L17-L20)
and capsuleConfiguration CRD
https://github.com/clastix/capsule/blob/953cfdc172dd1dd93646dd8609cda61071c8528a/charts/capsule/crds/capsuleconfiguration-crd.yaml#L18-L21

specifies v1beta2 in conversionReviewVersions.

But in tlsReconciler this version is missing:

https://github.com/clastix/capsule/blob/953cfdc172dd1dd93646dd8609cda61071c8528a/controllers/tls/manager.go#L243
@MaxFedotov MaxFedotov added bug Something isn't working blocked-needs-validation Issue need triage and validation labels Apr 20, 2023
@MaxFedotov MaxFedotov self-assigned this Apr 20, 2023
@MaxFedotov MaxFedotov mentioned this issue Apr 20, 2023
Merged
@prometherion prometherion removed the blocked-needs-validation Issue need triage and validation label Apr 25, 2023
@prometherion prometherion modified the milestones: v0.3.1, v0.3.2 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxFedotov MaxFedotov

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3.2
Development

Successfully merging a pull request may close this issue.

fix: missing v1beta2 version for CRD ConversionReviewVersions wgsateam/capsule
2 participants
@prometherion @MaxFedotov