Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: service controller not skipping sentinel errs #654

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix: service controller not skipping sentinel errs #654

merged 1 commit into from
Oct 14, 2022

Conversation

Al-Pragliola
Copy link

fixes #653

@netlify
Copy link

netlify bot commented Oct 14, 2022 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 56bc852
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/634992e8d5a7710009b8c9a9

prometherion
prometherion approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@prometherion prometherion merged commit ede96f5 into projectcapsule:master Oct 14, 2022
@Al-Pragliola Al-Pragliola deleted the fix/issue-653 branch October 14, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service controller doesn't skip sentinel error
2 participants
@Al-Pragliola @prometherion