Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service controller doesn't skip sentinel error #653

Closed
prometherion opened this issue Oct 14, 2022 · 0 comments · Fixed by #654
Closed

Service controller doesn't skip sentinel error #653

prometherion opened this issue Oct 14, 2022 · 0 comments · Fixed by #654
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Milestone

Comments

@prometherion
Copy link
Member

Bug description

The Operator is reporting sentinel errors, although these should be ignored to don't occupy the workqueue.

How to reproduce

Steps to reproduce the behavior:

apiVersion: capsule.clastix.io/v1beta1
kind: Tenant
metadata:
  annotations:
    capsule.clastix.io/deny-wildcard: "false"
    clusterrolenames.capsule.clastix.io/0: admin,capsule-namespace-deleter
    clusterrolenames.capsule.clastix.io/1: admin,capsule-namespace-deleter
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"capsule.clastix.io/v1beta2","kind":"Tenant","metadata":{"annotations":{},"name":"solar"},"spec":{"owners":[{"kind":"Group","name":"solar"}]}}
  creationTimestamp: "2022-10-14T15:12:02Z"
  generation: 2
  name: solar
  resourceVersion: "766268"
  uid: 8fc4445b-3eef-4460-b3fb-c4202e657af7
spec:
  ingressOptions:
    hostnameCollisionScope: Disabled
  limitRanges: {}
  networkPolicies: {}
  owners:
  - kind: User
    name: alice
  - kind: Group
    name: solar
  resourceQuotas:
    scope: Tenant

Expected behaviour

No error should be reported since it's a sentinel one.

Logs

2022-10-14T17:22:45.398+0200    ERROR   controller-runtime.manager.controller.service   Reconciler error        {"reconciler group": "", "reconciler kind": "Service", "name": "postgresql-r", "namespace": "solar-2", "error": "Skipping labels sync for postgresql-r because no AdditionalLabels or AdditionalAnnotations presents in Tenant spec"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
        /home/prometherion/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
        /home/prometherion/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:214

Additional context

  • Capsule version: v0.1.2
  • Helm Chart version: N.R.
  • Kubernetes version: N.R.
@prometherion prometherion added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Oct 14, 2022
@prometherion prometherion added this to the v0.2.0 milestone Oct 14, 2022
@prometherion prometherion modified the milestones: v0.2.0, v0.1.3 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant