Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.23] Auto pick #6302: Fix serviceaccount token generation for canal #6323

Conversation

caseydavenport
Copy link
Member

Cherry pick of #6302 on release-v3.23.

#6302: Fix serviceaccount token generation for canal

Original PR Body below

Description

We missed that Canal uses a different service account name than vanilla
Calico.

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix serviceaccount token generation for canal (introduced in v3.23.2)

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@caseydavenport caseydavenport requested a review from a team as a code owner July 6, 2022 17:35
@caseydavenport caseydavenport added cherry-pick-candidate docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small) labels Jul 6, 2022
@marvin-tigera marvin-tigera added this to the Calico v3.23.3 milestone Jul 6, 2022
@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for calico-v3-23 ready!

Name Link
🔨 Latest commit d07d05d
🔍 Latest deploy log https://app.netlify.com/sites/calico-v3-23/deploys/62c5c7fb21949e00095fb1da
😎 Deploy Preview https://deploy-preview-6323--calico-v3-23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for calico-tigera ready!

Name Link
🔨 Latest commit d07d05d
🔍 Latest deploy log https://app.netlify.com/sites/calico-tigera/deploys/62c5c7fbfcfa0b0008fdc750
😎 Deploy Preview https://deploy-preview-6323--calico-tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@caseydavenport caseydavenport merged commit d31368e into projectcalico:release-v3.23 Jul 7, 2022
@caseydavenport caseydavenport deleted the auto-pick-of-#6302-origin-release-v3.23 branch July 7, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants