Refactor logging #93
Merged
Refactor logging #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested as working on DDP. The values of loss at epoch and Dice at epoch on ModelCheckpoint and Logger match |
ibro45
force-pushed
the
logger
branch
2 times, most recently
from
d55ed81
to
4fa5dc7
Compare
|
@ibro45 Can we merge this? Good to have a fixed version of lighter for the experiments. |
|
Alright, if you agree with everything we can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove LighterLogger and use default PL loggers instead. No input/pred/target logging for the moment.
Related Issue
#92
#19
Type of Change