-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename admin pairing class and usage to fabric #8479
Rename admin pairing class and usage to fabric #8479
Conversation
becad62
to
05e52b9
Compare
Any functional changes? If not can you assert this in the description please? If so can you avoid functional changes in a rename PR? "Just a rename, no functional change." |
05e52b9
to
ba6781d
Compare
- Just a rename, no functional changes
ba6781d
to
3a62b8e
Compare
Size increase report for "esp32-example-build" from f15ed2e
Full report output
|
Size increase report for "nrfconnect-example-build" from f15ed2e
Full report output
|
@saurabhst do you have any review feedback? |
* Rename AdminPairing class and usage to Fabric - Just a rename, no functional changes * address review comments
Problem
AdminPairingTable and AdminPairingInfo should be renamed to Fabric to match latest specifications.
Change overview
Update the class and its usage.
Note: more changes are needed in the class to bring it up to the spec. This PR is specifically only renaming the class and its usage, to prevent mixing the large rename change with more specific logic change in the class.
Testing
Existing unit tests, and pairing using chip-tool, Python controller, and iOS controller apps.