Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
pan-apple committed Jul 20, 2021
1 parent 46b071c commit ba6781d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions src/transport/FabricTable.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,16 @@ static constexpr uint8_t kFabricLabelMaxLengthInBytes = 32;

// KVS store is sensitive to length of key strings, based on the underlying
// platform. Keeping them short.
constexpr char kFabricTableKeyPrefix[] = "CHIPAdmin";
constexpr char kFabricTableCountKey[] = "CHIPAdminNextId";
constexpr char kFabricTableKeyPrefix[] = "Fabric";
constexpr char kFabricTableCountKey[] = "NumFabrics";

struct AccessControlList
{
uint32_t placeholder;
};

/**
* Defines state of a pairing established by an fabric.
* Defines state of a pairing established by a fabric.
* ACL data can be mutated throughout the lifetime of the fabric pairing.
* Node ID is only settable using the device operational credentials.
*
Expand Down Expand Up @@ -228,17 +228,17 @@ class DLL_EXPORT FabricTableDelegate
public:
virtual ~FabricTableDelegate() {}
/**
* Gets called when an fabric is deleted from KVS store.
* Gets called when a fabric is deleted from KVS store.
**/
virtual void OnFabricDeletedFromStorage(FabricIndex fabricId) = 0;

/**
* Gets called when an fabric is loaded into Fabric Table from KVS store.
* Gets called when a fabric is loaded into Fabric Table from KVS store.
**/
virtual void OnFabricRetrievedFromStorage(FabricInfo * fabricInfo) = 0;

/**
* Gets called when an fabric in Fabric Table is persisted to KVS store.
* Gets called when a fabric in Fabric Table is persisted to KVS store.
**/
virtual void OnFabricPersistedToStorage(FabricInfo * fabricInfo) = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion src/transport/SecureSessionMgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ void SecureSessionMgr::SecureMessageDispatch(const PacketHeader & packetHeader,
}

// See operational-credentials-server.cpp for explanation as to why fabricId is being set to commissioner node id
// This is temporary code until AddOptCert is implemented through which an fabric will be correctly added with the correct
// This is temporary code until AddOptCert is implemented through which a fabric will be correctly added with the correct
// fields.
// TODO: Remove temporary code once AddOptCert is implemented
if (packetHeader.GetSourceNodeId().HasValue())
Expand Down

0 comments on commit ba6781d

Please sign in to comment.