Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Support passing csr nonce into commissioning flow #7697

Closed
wants to merge 32 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jun 16, 2021

A duplicate of #7696 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2021

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from cd007ca to 3c53f95 Compare June 18, 2021 01:03
@todo
Copy link

todo bot commented Jun 18, 2021

(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.

// TODO(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.
wasHandled = emberAfThreadNetworkDiagnosticsClusterResetCountsCallback(apCommandObj);
break;
}
default: {
// Unrecognized command ID, error status will apply.
chip::app::CommandPathParams returnStatusParam = { aEndpointId,
0, // GroupId
ZCL_THREAD_NETWORK_DIAGNOSTICS_CLUSTER_ID, aCommandId,
(chip::app::CommandPathFlags::kEndpointIdValid) };
apCommandObj->AddStatusCode(returnStatusParam, Protocols::SecureChannel::GeneralStatusCode::kNotFound,


This comment was generated by todo based on a TODO comment in 3c53f95 in #7697. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from 3c53f95 to e278357 Compare June 18, 2021 18:46
@todo
Copy link

todo bot commented Jun 18, 2021

Use Android keystore system instead of direct storage of private key and add specific errors to check if a specified

// TODO: Use Android keystore system instead of direct storage of private key and add specific errors to check if a specified
// item is not found in the keystore.
if (SyncGetKeyValue(kOperationalCredentialsIssuerKeypairStorage, &serializedKey, keySize) != CHIP_NO_ERROR)
{
// If storage doesn't have an existing keypair, create one and add it to the storage.
ReturnErrorOnFailure(mIssuer.Initialize());
ReturnErrorOnFailure(mIssuer.Serialize(serializedKey));
keySize = static_cast<uint16_t>(sizeof(serializedKey));
SyncSetKeyValue(kOperationalCredentialsIssuerKeypairStorage, &serializedKey, keySize);
}
else


This comment was generated by todo based on a TODO comment in e278357 in #7697. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from e278357 to 1ba304f Compare June 18, 2021 22:32
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from 1ba304f to 333516c Compare June 21, 2021 18:06
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from 333516c to fbdd763 Compare June 21, 2021 18:22
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from fbdd763 to af8fa7d Compare June 21, 2021 19:09
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from af8fa7d to e3ca338 Compare June 21, 2021 21:20
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from e3ca338 to 79cfe0a Compare June 21, 2021 21:51
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from 79cfe0a to 135c93c Compare June 22, 2021 18:43
@todo
Copy link

todo bot commented Jun 22, 2021

Refactor this API to match latest spec, so that GenerateNodeOperationalCertificate receives the full CSR Elements data

// TODO Refactor this API to match latest spec, so that GenerateNodeOperationalCertificate receives the full CSR Elements data
// payload.
CHIP_ERROR AndroidDeviceControllerWrapper::GenerateNodeOperationalCertificate(const chip::PeerId & peerId,
const chip::ByteSpan & csr, int64_t serialNumber,
uint8_t * certBuf, uint32_t certBufSize,
uint32_t & outCertLen)
{
jmethodID method;
CHIP_ERROR err = CHIP_NO_ERROR;
err = FindMethod(JniReferences::GetEnvForCurrentThread(), mJavaObjectRef, "onOpCSRGenerationComplete", "([B)V", &method);
if (err != CHIP_NO_ERROR)


This comment was generated by todo based on a TODO comment in 135c93c in #7697. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from 135c93c to 2ac977c Compare June 22, 2021 18:46
@todo
Copy link

todo bot commented Jun 22, 2021

Abstract the CSRNonce generation from the CHIPDevice and let the controller always provide it.

// TODO Abstract the CSRNonce generation from the CHIPDevice and let the controller always provide it.
// This will entail, making the CSRNonce a mandatory init param and also fixing the flow which currently depends on the auto
// generation of the CSRNonce.
device->GenerateCSRNonce();
}
mIsIPRendezvous = (params.GetPeerAddress().GetTransportType() != Transport::Type::kBle);
err = mPairingSession.MessageDispatch().Init(mTransportMgr);


This comment was generated by todo based on a TODO comment in 2ac977c in #7697. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from 2ac977c to c356059 Compare June 22, 2021 19:26
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from c356059 to 0f4039f Compare June 23, 2021 17:36
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from 0f4039f to de479ed Compare June 23, 2021 21:33
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from de479ed to 38a139e Compare June 23, 2021 21:56
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from 38a139e to b30e7c1 Compare June 24, 2021 04:02
@restyled-io restyled-io bot force-pushed the restyled/pull-7696 branch from b30e7c1 to f083412 Compare June 24, 2021 17:32
@restyled-io restyled-io bot closed this Jun 25, 2021
@restyled-io restyled-io bot deleted the restyled/pull-7696 branch June 25, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants