-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle Support passing csr nonce into commissioning flow #7697
Conversation
…_Commissioning_flow
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
cd007ca
to
3c53f95
Compare
(#5098) We should pass the Command Object and EndpointId to the cluster callbacks.connectedhomeip/examples/window-app/common/gen/IMClusterCommandHandler.cpp Lines 1453 to 1463 in 3c53f95
This comment was generated by todo based on a
|
3c53f95
to
e278357
Compare
Use Android keystore system instead of direct storage of private key and add specific errors to check if a specifiedconnectedhomeip/src/controller/java/AndroidDeviceControllerWrapper.cpp Lines 191 to 201 in e278357
This comment was generated by todo based on a
|
e278357
to
1ba304f
Compare
…_Commissioning_flow
1ba304f
to
333516c
Compare
…_Commissioning_flow
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
333516c
to
fbdd763
Compare
…_Commissioning_flow
fbdd763
to
af8fa7d
Compare
…_Commissioning_flow
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
af8fa7d
to
e3ca338
Compare
e3ca338
to
79cfe0a
Compare
79cfe0a
to
135c93c
Compare
Refactor this API to match latest spec, so that GenerateNodeOperationalCertificate receives the full CSR Elements dataconnectedhomeip/src/controller/java/AndroidDeviceControllerWrapper.cpp Lines 153 to 163 in 135c93c
This comment was generated by todo based on a
|
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
135c93c
to
2ac977c
Compare
Abstract the CSRNonce generation from the CHIPDevice and let the controller always provide it.connectedhomeip/src/controller/CHIPDeviceController.cpp Lines 835 to 843 in 2ac977c
This comment was generated by todo based on a
|
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
2ac977c
to
c356059
Compare
…_Commissioning_flow
c356059
to
0f4039f
Compare
…_Commissioning_flow
…_Commissioning_flow
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
0f4039f
to
de479ed
Compare
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
…tps://github.com/ritikananda27/connectedhomeip into Support_Passing_CSRNonce_into_Commissioning_flow
de479ed
to
38a139e
Compare
38a139e
to
b30e7c1
Compare
b30e7c1
to
f083412
Compare
A duplicate of #7696 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.