-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IM] Add Command object and endpoint id to params of current command handlers #5098
Comments
This was referenced Apr 15, 2021
This was referenced May 4, 2021
This was referenced Jun 17, 2021
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Then it will be better to fix the current commands handlers to have a new parameter for it in a separate PR.
Please remove
src/app/clusters/im-compatibility
, it introduce a new generated folder insrc/
and creates a level of indirection that does not seems really needed.Originally posted by @vivien-apple in #5032 (comment)
Currently, the commands are using a global emberApsFrame & emberAfCluster object, this does not meet the needs of the requirement of CHIP datamodel.
The IME provideds a Command* object, and the command handlers in the future should be able to make use of them.
The text was updated successfully, but these errors were encountered: