Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IM] Add Command object and endpoint id to params of current command handlers #5098

Closed
erjiaqing opened this issue Mar 2, 2021 · 0 comments · Fixed by #5994 or #8644
Closed

[IM] Add Command object and endpoint id to params of current command handlers #5098

erjiaqing opened this issue Mar 2, 2021 · 0 comments · Fixed by #5994 or #8644

Comments

@erjiaqing
Copy link
Contributor

erjiaqing commented Mar 2, 2021

Problem

Then it will be better to fix the current commands handlers to have a new parameter for it in a separate PR.
Please remove src/app/clusters/im-compatibility, it introduce a new generated folder in src/ and creates a level of indirection that does not seems really needed.

Originally posted by @vivien-apple in #5032 (comment)

Currently, the commands are using a global emberApsFrame & emberAfCluster object, this does not meet the needs of the requirement of CHIP datamodel.

The IME provideds a Command* object, and the command handlers in the future should be able to make use of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant