Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix XML comments in opcreds cluster" #7678

Closed
wants to merge 1 commit into from

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jun 16, 2021

Reverts #7598

@todo
Copy link

todo bot commented Jun 16, 2021

Once FabricIndex is implemented, have RemoveFabric take an index instead of vid+fabricId+nopeId

// TODO: Once FabricIndex is implemented, have RemoveFabric take an index instead of vid+fabricId+nopeId
<command source="client" code="0x0a" name="RemoveFabric" optional="false">
<description>This command is used by Administrative Nodes to remove a given Fabric and delete all associated
fabric-scoped data.</description>


This comment was generated by todo based on a TODO comment in bd1b03a in #7678. cc @project-chip.

@boring-cyborg boring-cyborg bot added the app label Jun 16, 2021
@todo
Copy link

todo bot commented Jun 16, 2021

Remove SetFabric + SetFabricResponse once addOptCert command is implemented

// TODO: Remove SetFabric + SetFabricResponse once addOptCert command is implemented
<command source="client" code="0x00" name="SetFabric" optional="false">
<description>Sets the vendorID of the fabric and returns the fabricId of newly created fabric.</description>
<arg name="VendorId" type="INT16U"/>


This comment was generated by todo based on a TODO comment in bd1b03a in #7678. cc @project-chip.

@mspang mspang added hotfix urgent fix needed, can bypass review and removed review - pending labels Jun 16, 2021
@pullapprove pullapprove bot added review - pending and removed hotfix urgent fix needed, can bypass review labels Jun 16, 2021
@woody-apple
Copy link
Contributor

#7677 ?

@mspang mspang closed this Jun 16, 2021
@woody-apple woody-apple deleted the revert-7598-patch-1 branch July 3, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants