Fix XML comments in opcreds cluster #7598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once FabricIndex is implemented, have RemoveFabric take an index instead of vid+fabricId+nopeId -->This comment was generated by todo based on a
|
Remove SetFabric + SetFabricResponse once AddOpCert command is implemented -->This comment was generated by todo based on a
|
Fix to match chip-spec:#3346 -->This comment was generated by todo based on a
|
|
|
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
Damian-Nordic
approved these changes
Jun 14, 2021
msandstedt
approved these changes
Jun 14, 2021
andy31415
approved these changes
Jun 14, 2021
mspang
approved these changes
Jun 14, 2021
woody-apple
approved these changes
Jun 15, 2021
|
/rebase |
- Also remove a TODO that is fixed. - Add TODO about CSR format
Once FabricIndex is implemented, have RemoveFabric take an index instead of vid+fabricId+nopeId -->This comment was generated by todo based on a
|
Remove SetFabric + SetFabricResponse once AddOpCert command is implemented -->This comment was generated by todo based on a
|
Fix to match chip-spec:#3346 -->This comment was generated by todo based on a
|
This was referenced Jun 16, 2021
erjiaqing
added a commit
to erjiaqing/connectedhomeip
that referenced
this pull request
Jun 16, 2021
woody-apple
pushed a commit
that referenced
this pull request
Jun 16, 2021
Per @yunhanw-google this appears to fix the build, force merging in.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
- Also remove a TODO that is fixed. - Add TODO about CSR format
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Per @yunhanw-google this appears to fix the build, force merging in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Comments in OpCreds cluster XML use C++ style rather than XML style
Change overview
Testing