Move the constraint check for number of presets not to exceed the num… #35167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
|
PR #35167: Size comparison from daa2a57 to bc1cba0 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
nivi-apple
force-pushed
the
remove_check_for_max_number_of_presets_supported_to_Write
branch
from
bc1cba0 to
353fefe
Compare
…ber of presets supported from the atomic write commit command handling to the write request
nivi-apple
force-pushed
the
remove_check_for_max_number_of_presets_supported_to_Write
branch
from
353fefe to
739a3d7
Compare
|
PR #35167: Size comparison from c1b3304 to 739a3d7 Full report (3 builds for nxp, stm32)
|
hasty
reviewed
Aug 23, 2024
src/app/clusters/thermostat-server/thermostat-server-presets.cpp
Outdated
Show resolved
Hide resolved
hasty
reviewed
Aug 23, 2024
src/app/clusters/thermostat-server/thermostat-server-presets.cpp
Outdated
Show resolved
Hide resolved
|
PR #35167: Size comparison from c1b3304 to f776c5d Full report (3 builds for nxp, stm32)
|
hasty
reviewed
Aug 23, 2024
src/app/clusters/thermostat-server/thermostat-server-presets.cpp
Outdated
Show resolved
Hide resolved
hasty
approved these changes
Aug 23, 2024
|
PR #35167: Size comparison from c1b3304 to 3826af1 Full report (10 builds for nrfconnect, nxp, qpg, stm32)
|
- Also no need to check if numberOfPresetsSupported is 0.
nivi-apple
force-pushed
the
remove_check_for_max_number_of_presets_supported_to_Write
branch
from
3826af1 to
cf05a20
Compare
|
PR #35167: Size comparison from c1b3304 to cf05a20 Full report (75 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Aug 23, 2024
src/app/clusters/thermostat-server/thermostat-server-presets.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
approved these changes
Aug 23, 2024
src/app/clusters/thermostat-server/thermostat-server-presets.cpp
Outdated
Show resolved
Hide resolved
|
PR #35167: Size comparison from c1b3304 to f0eafac Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ReneJosefsen
approved these changes
Aug 26, 2024
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
project-chip#35167) * Move the constraint check for number of presets not to exceed the number of presets supported from the atomic write commit command handling to the write request * Minor fix * Do not check if totalExpectedCount > 0 since its an unsigned integer - Also no need to check if numberOfPresetsSupported is 0. * Update src/app/clusters/thermostat-server/thermostat-server-presets.cpp * Update src/app/clusters/thermostat-server/thermostat-server-presets.cpp --------- Co-authored-by: Boris Zbarsky <[email protected]>
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
project-chip#35167) * Move the constraint check for number of presets not to exceed the number of presets supported from the atomic write commit command handling to the write request * Minor fix * Do not check if totalExpectedCount > 0 since its an unsigned integer - Also no need to check if numberOfPresetsSupported is 0. * Update src/app/clusters/thermostat-server/thermostat-server-presets.cpp * Update src/app/clusters/thermostat-server/thermostat-server-presets.cpp --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ber of presets supported from the atomic write commit command handling to the write request
Fixes: #35166