Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the constraint check for the size of the presets or schedules attributes exceeding the total number supported from the atomic write commit request to the write request #35166

Closed
nivi-apple opened this issue Aug 23, 2024 · 0 comments · Fixed by #35167
Closed

Move the constraint check for the size of the presets or schedules attributes exceeding the total number supported from the atomic write commit request to the write request #35166

nivi-apple opened this issue Aug 23, 2024 · 0 comments · Fixed by #35167
Assignees
@nivi-apple
Labels
thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues

Comments

@nivi-apple
Copy link
Contributor

Currently the constraint check for the maximum number of presets or schedules allowed is done in the atomic write commit command which is incorrect. The check should be in the write request for these attributes

Corresponding to spec issue - https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/10313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nivi-apple nivi-apple

Labels
thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move the constraint check for number of presets not to exceed the num… nivi-apple/connectedhomeip
1 participant
@nivi-apple