Generate .matter IDL to contain global structures
#34545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 2 of 94 files. File Information
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien and
chrisdecenzo
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
bzbarsky-apple
approved these changes
Jul 26, 2024
|
PR #34545: Size comparison from 55786a0 to b0882bb Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Jul 26, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Starting a template implementation * Move file to propper location * Start adding some global types in codegen * Fix indent * Undo large changes and fix spacing * zap regen * Prepare to remove the extra Bitmap types * Different style workaround * Fix the condition ending to make it work * zap regen * Undo file change * Undo file change * Matter IDL indent is a bit better * Fighting with zap/handlebars intend... this is terrible * zap-regen * Self code review cleanup --------- Co-authored-by: Andrei Litvin <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Starting a template implementation * Move file to propper location * Start adding some global types in codegen * Fix indent * Undo large changes and fix spacing * zap regen * Prepare to remove the extra Bitmap types * Different style workaround * Fix the condition ending to make it work * zap regen * Undo file change * Undo file change * Matter IDL indent is a bit better * Fighting with zap/handlebars intend... this is terrible * zap-regen * Self code review cleanup --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds global structure support in matter IDL. Parsing for these was already done in #34515