Add global types (structs/enums/bitmaps) to matter file parsing #34515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248 and
hicklin
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34515: Size comparison from c91a779 to ac0ab05 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34515: Size comparison from 2a60735 to e199281 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 26, 2024
cecille
approved these changes
Jul 26, 2024
|
PR #34515: Size comparison from ade5285 to 64e9b54 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…ect-chip#34515) * Make the IDL parser parse global types * Restyle * Parsing ok, started adding compatibility unit tests (which fail) * backwards compatibility tests pass now * Start implementing global type merging. Still needs unit tests * Prepare matter tests * A first test for global parsing * Fix bugs and have a working unit test for the non-recursive bit * Recursive unit test passes * Fix lint * Fix lint * Add check for global type uniqueness * Restyle --------- Co-authored-by: Andrei Litvin <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…ect-chip#34515) * Make the IDL parser parse global types * Restyle * Parsing ok, started adding compatibility unit tests (which fail) * backwards compatibility tests pass now * Start implementing global type merging. Still needs unit tests * Prepare matter tests * A first test for global parsing * Fix bugs and have a working unit test for the non-recursive bit * Recursive unit test passes * Fix lint * Fix lint * Add check for global type uniqueness * Restyle --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
struct/bitmap/enumat a top level in matter files