Add support for Presets attributes and commands to the Thermostat cluster #34532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster Clean up the Thermostat cluster and remove the TemperatureSetpointHoldPolicy attribute and SetTemperatureSetpointHoldPolicy command
nivi-apple
force-pushed
the
add_presets_to_Sdk
branch
from
e806acb to
09332ef
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
|
PR #34532: Size comparison from 93e5e85 to ffdbb24 Increases above 0.2%:
Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
src/app/zap-templates/zcl/data-model/chip/thermostat-cluster.xml
Outdated
Show resolved
Hide resolved
nivi-apple
force-pushed
the
add_presets_to_Sdk
branch
from
ffdbb24 to
9c511bf
Compare
|
PR #34532: Size comparison from 55786a0 to 9c511bf Increases above 0.2%:
Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #34532: Size comparison from 55786a0 to f027069 Full report (21 builds for bl602, bl702, bl702l, cc13x4_26x4, mbed, nxp, stm32)
|
nivi-apple
force-pushed
the
add_presets_to_Sdk
branch
from
47a8692 to
a2bb5d6
Compare
|
PR #34532: Size comparison from f4d9188 to 0147c71 Increases above 0.2%:
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 28, 2024
src/app/clusters/thermostat-server/PresetStructWithOwnedMembers.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #34532: Size comparison from d9bcdd3 to 259cd5d Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Should Thermostat cluster revision be updated to 7? |
nivi-apple
force-pushed
the
add_presets_to_Sdk
branch
from
b801c13 to
abee68b
Compare
|
PR #34532: Size comparison from 295ad53 to abee68b Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
fessehaeve
approved these changes
Jul 29, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…ster (project-chip#34532) * Add support for Presets attributes and commands to the Thermostat cluster Clean up the Thermostat cluster and remove the TemperatureSetpointHoldPolicy attribute and SetTemperatureSetpointHoldPolicy command * Restyled by whitespace * Restyled by clang-format * Restyled by gn. * Fix build error for Linux configure build of all-clusters-app * Fix Darwin CI issues Editorial fixes * Restyled by clang-format * More fixes * Restyled by clang-format * BUILD.gn fixes for CI * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments. * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Remove Presets and Schedules attributes from all-cluster-app.zap. --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…ster (project-chip#34532) * Add support for Presets attributes and commands to the Thermostat cluster Clean up the Thermostat cluster and remove the TemperatureSetpointHoldPolicy attribute and SetTemperatureSetpointHoldPolicy command * Restyled by whitespace * Restyled by clang-format * Restyled by gn. * Fix build error for Linux configure build of all-clusters-app * Fix Darwin CI issues Editorial fixes * Restyled by clang-format * More fixes * Restyled by clang-format * BUILD.gn fixes for CI * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments. * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Remove Presets and Schedules attributes from all-cluster-app.zap. --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the Thermostat cluster and remove the TemperatureSetpointHoldPolicy attribute and SetTemperatureSetpointHoldPolicy command
Fixes: #34531
Added the skip-protocol-compatibility flag in the PR because of the following updates.
The 1.4 spec has updated PresetScenarioEnum with a new value added. Hence vacation has changed its value.
Also sdk had SetTemperatureSetpointHoldPolicyRequest command, TemperatureSetpointHoldPolicyBitmap and temperatureSetpointHoldPolicy attribute that has been removed from the spec. Hence setpointHoldExpiryTimestamp changed its code.
Following are the changes flagged by the compatibility checker -
2024-07-26 07:53:09 ERROR Enumeration Thermostat::PresetScenarioEnum changed code for entry kUserDefined from 6 to 7
2024-07-26 07:53:09 ERROR Struct Thermostat::SetTemperatureSetpointHoldPolicyRequest has been deleted.
2024-07-26 07:53:09 ERROR Bitmap Thermostat::TemperatureSetpointHoldPolicyBitmap was deleted
2024-07-26 07:53:09 ERROR Command Thermostat::SetTemperatureSetpointHoldPolicy was removed
2024-07-26 07:53:09 ERROR Attribute Thermostat::temperatureSetpointHoldPolicy has been deleted.
2024-07-26 07:53:09 ERROR Attribute Thermostat::setpointHoldExpiryTimestamp changed its code.