Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comments on PR #34532 (use CHIP_ERROR_IM_GLOBAL_STATUS_VALUE instead of reinventing it) #34591

Closed
nivi-apple opened this issue Jul 29, 2024 · 0 comments · Fixed by #34781
Closed

fix comments on PR #34532 (use CHIP_ERROR_IM_GLOBAL_STATUS_VALUE instead of reinventing it) #34591

nivi-apple opened this issue Jul 29, 2024 · 0 comments · Fixed by #34781
Assignees
@nivi-apple
Labels
thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues

Comments

@nivi-apple
Copy link
Contributor

#34532 (comment)
@nivi-apple nivi-apple self-assigned this Jul 29, 2024
@nivi-apple nivi-apple added the thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues label Jul 29, 2024
@nivi-apple nivi-apple mentioned this issue Jul 29, 2024
Merged
@bzbarsky-apple bzbarsky-apple changed the title fix comments on PR #34532 fix comments on PR #34532 (use CHIP_ERROR_IM_GLOBAL_STATUS_VALUE instead of reinventing it) Jul 29, 2024
@nivi-apple nivi-apple mentioned this issue Aug 5, 2024
Merged
@mergify mergify bot closed this as completed in #34781 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nivi-apple nivi-apple

Labels
thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace ChipErrorFromStatusCode with CHIP_ERROR_IM_GLOBAL_STATUS_VALUE nivi-apple/connectedhomeip
1 participant
@nivi-apple