-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Update ThreadStackManagerImpl #34389
Merged
mergify
merged 4 commits into
project-chip:master
from
lpbeliveau-silabs:feature/thread-manager-impl-update
Jul 20, 2024
Merged
[Silabs] Update ThreadStackManagerImpl #34389
mergify
merged 4 commits into
project-chip:master
from
lpbeliveau-silabs:feature/thread-manager-impl-update
Jul 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
added
the
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
label
Jul 18, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
July 18, 2024 13:54
PR #34389: Size comparison from b88ac27 to a82a2bb Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
lpbeliveau-silabs
force-pushed
the
feature/thread-manager-impl-update
branch
from
July 18, 2024 14:50
0193993
to
bc000ac
Compare
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
Outdated
Show resolved
Hide resolved
rcasallas-silabs
approved these changes
Jul 18, 2024
lpbeliveau-silabs
force-pushed
the
feature/thread-manager-impl-update
branch
2 times, most recently
from
July 18, 2024 15:16
c6a6475
to
4aace4c
Compare
PR #34389: Size comparison from b88ac27 to 4aace4c Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 18, 2024
… added a helper in GenericThreadStackManagerImpl_OpenThread.hpp to avoid code repetition Fixes for memory allocation initialization added since, unlike in SLC, here we use MBEDTLS_CONFIG_FILE="efr32-chip-mbedtls-config.h"
lpbeliveau-silabs
force-pushed
the
feature/thread-manager-impl-update
branch
2 times, most recently
from
July 19, 2024 13:29
67f1ee3
to
276667a
Compare
PR #34389: Size comparison from fca7948 to 276667a Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
force-pushed
the
feature/thread-manager-impl-update
branch
from
July 19, 2024 17:22
276667a
to
7461735
Compare
PR #34389: Size comparison from 483af54 to 7461735 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
force-pushed
the
feature/thread-manager-impl-update
branch
from
July 19, 2024 19:24
7461735
to
4c4db9c
Compare
PR #34389: Size comparison from e7380a1 to 4c4db9c Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
lpbeliveau-silabs
force-pushed
the
feature/thread-manager-impl-update
branch
from
July 19, 2024 19:54
4c4db9c
to
0478e63
Compare
PR #34389: Size comparison from e7380a1 to 0478e63 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
lpbeliveau-silabs
force-pushed
the
feature/thread-manager-impl-update
branch
from
July 19, 2024 20:55
0478e63
to
2b3ace0
Compare
PR #34389: Size comparison from e7380a1 to 2b3ace0 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
force-pushed
the
feature/thread-manager-impl-update
branch
from
July 19, 2024 22:19
2b3ace0
to
5271440
Compare
PR #34389: Size comparison from 19a774a to 5271440 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Updated Silabs ThreadStackManagerImpl for the Simplicity_sdk changes, added a helper in GenericThreadStackManagerImpl_OpenThread.hpp to avoid code repetition Fixes for memory allocation initialization added since, unlike in SLC, here we use MBEDTLS_CONFIG_FILE="efr32-chip-mbedtls-config.h" * Updated matter support * Added ClearThreadStack Helper * Grouped extern C statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changing-submodules-on-purpose
Marker that this PR is changing submodules (and it is not a "commit all" typo/mistake)
examples
platform
review - approved
silabs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of Silabs code to use latest Simplicity SDK changes.
There IS a small change to the
GenericThreadStackManagerImpl_OpenThread
where I added a helper to allow to call parts of DoInit from a ThreadStackManagerImpl without code dupplication.