Grouped extern C statements

project-chip · Jul 19, 2024 · 0478e63 · 0478e63
1 parent 1443a45
commit 0478e63
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/examples/platform/silabs/BaseApplication.h b/examples/platform/silabs/BaseApplication.h
@@ -165,8 +165,8 @@ class BaseApplication
     static void UpdateCommissioningStatus(bool newState);
 
     /**
-     * @brief Called when the last Fabric is removed, clears all Fabric related data and Thread  Wifi provision.
-     * @note This function preserves some NVM3 data that is not Fabric scoped like Attribute Value or Boot Count.
+     * @brief Called when the last Fabric is removed, clears all Fabric related data, including Thread and Wifi provision.
+     * @note This function preserves some NVM3 data that is not Fabric scoped, like Attribute Value or Boot Count.
      */
     static void DoProvisioningReset();
 

diff --git a/src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp b/src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
@@ -1090,7 +1090,7 @@ CHIP_ERROR GenericThreadStackManagerImpl_OpenThread<ImplClass>::_GetPollPeriod(u
 
 /**
  * @brief Helper that sets callbacks for OpenThread state changes and configures the Thread stack.
- * Assigns mOTInst to and instance and configures the OT stack on a device by setting state change callbacks enabling features
+ * Assigns mOTInst to an instance, and configures the OT stack on a device by setting state change callbacks enabling features
  * for IPv6 address configuration, enabling the Thread network if necessary, and handling SRP if enabled.
  * Allows for the configuration of the Thread stack on a device where the instance and the otCLI are already initialised.
  *

diff --git a/src/platform/silabs/efr32/ThreadStackManagerImpl.cpp b/src/platform/silabs/efr32/ThreadStackManagerImpl.cpp
@@ -41,36 +41,33 @@
 
 extern "C" {
 #include "platform-efr32.h"
-}
-
-// Forward declaration
-extern "C" otInstance * otGetInstance(void);
-
+otInstance * otGetInstance(void);
 #if CHIP_DEVICE_CONFIG_THREAD_ENABLE_CLI
-extern "C" void otAppCliInit(otInstance * aInstance);
-#endif
+void otAppCliInit(otInstance * aInstance);
+#endif // CHIP_DEVICE_CONFIG_THREAD_ENABLE_CLI
+}
 
 namespace chip {
 namespace DeviceLayer {
 namespace {
 otInstance * sOTInstance = NULL;
 
 // Network commissioning
-#ifndef _NO_NETWORK_COMMISSIONING_DRIVER_
+#ifndef _NO_GENERIC_THREAD_NETWORK_COMMISSIONING_DRIVER_
 NetworkCommissioning::GenericThreadDriver sGenericThreadDriver;
 app::Clusters::NetworkCommissioning::Instance sThreadNetworkCommissioningInstance(0 /* Endpoint Id */, &sGenericThreadDriver);
 #endif
 
 void initStaticNetworkCommissioningThreadDriver(void)
 {
-#ifndef _NO_NETWORK_COMMISSIONING_DRIVER_
+#ifndef _NO_GENERIC_THREAD_NETWORK_COMMISSIONING_DRIVER_
     sThreadNetworkCommissioningInstance.Init();
 #endif
 }
 
 void shutdownStaticNetworkCommissioningThreadDriver(void)
 {
-#ifndef _NO_NETWORK_COMMISSIONING_DRIVER_
+#ifndef _NO_GENERIC_THREAD_NETWORK_COMMISSIONING_DRIVER_
     sThreadNetworkCommissioningInstance.Shutdown();
 #endif
 }

diff --git a/third_party/silabs/BUILD.gn b/third_party/silabs/BUILD.gn
@@ -211,6 +211,7 @@ if (wifi_soc != true) {  # CCP board
 
         include_dirs = [ "${sl_ot_platform_abstraction}/include" ]
       }
+      sources += [ "${sl_ot_platform_abstraction}/efr32/sleep.c" ]
 
       # Use silabs openthread library stack with or without coap api enabled
       COAP_API = ""

diff --git a/third_party/silabs/efr32_sdk.gni b/third_party/silabs/efr32_sdk.gni
@@ -916,6 +916,8 @@ template("efr32_sdk") {
       sources += [
         "${efr32_sdk_root}/hardware/driver/configuration_over_swo/src/sl_cos.c",
         "${efr32_sdk_root}/platform/driver/debug/src/sl_debug_swo.c",
+        "${efr32_sdk_root}/util/third_party/mbedtls/library/hmac_drbg.c",
+        "${efr32_sdk_root}/util/third_party/mbedtls/library/psa_crypto_ecp.c",
       ]
     }