Make use of ZAP's new support for specifying the parent of an endpoint. #32487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
yufengwangca
approved these changes
Mar 7, 2024
|
PR #32487: Size comparison from 9df9200 to c1b2e0e Increases (64 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Mar 7, 2024
Specific changes: * Remove unused FIXED_NETWORKS bit from endpoint_config.h. * Add FIXED_PARENT_ENDPOINTS which lists the parents of each fixed endpoint. * Condition the fixed endpoint initialization code on FIXED_ENDPOINT_COUNT > 0 and remove some Darwin hackery that was needed because it was not thus conditioned. * Add initialization of parentEndpointId for fixed endpoints from FIXED_PARENT_ENDPOINTS. At the moment FIXED_PARENT_ENDPOINTS uses 0 to mean "no parent specified", but I am hoping the ZAP folks will fix things so that we can just have kInvalidEndpointId in there and the code in emberAfEndpointConfigure can become simpler/smaller.
bzbarsky-apple
force-pushed
the
parent-endpoint-zap
branch
from
c1b2e0e to
50273f2
Compare
|
PR #32487: Size comparison from 807d03a to 50273f2 Increases (64 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
lpbeliveau-silabs
approved these changes
Mar 12, 2024
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…t. (project-chip#32487) Specific changes: * Remove unused FIXED_NETWORKS bit from endpoint_config.h. * Add FIXED_PARENT_ENDPOINTS which lists the parents of each fixed endpoint. * Condition the fixed endpoint initialization code on FIXED_ENDPOINT_COUNT > 0 and remove some Darwin hackery that was needed because it was not thus conditioned. * Add initialization of parentEndpointId for fixed endpoints from FIXED_PARENT_ENDPOINTS. At the moment FIXED_PARENT_ENDPOINTS uses 0 to mean "no parent specified", but I am hoping the ZAP folks will fix things so that we can just have kInvalidEndpointId in there and the code in emberAfEndpointConfigure can become simpler/smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific changes:
At the moment FIXED_PARENT_ENDPOINTS uses 0 to mean "no parent specified", but I am hoping the ZAP folks will fix things so that we can just have kInvalidEndpointId in there and the code in emberAfEndpointConfigure can become simpler/smaller.