-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Provide core dump summary in response to crash diagnostic log requests #32331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
February 27, 2024 05:26
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 27, 2024 05:26
@tcarmelveilleux Please take a look. |
PR #32331: Size comparison from 28c78af to 821a477 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
shubhamdp
force-pushed
the
esp32_diag_log_crash
branch
from
February 27, 2024 06:53
821a477
to
e604bbc
Compare
PR #32331: Size comparison from a2d98f8 to e604bbc Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
examples/temperature-measurement-app/esp32/main/diagnostic-logs-provider-delegate-impl.cpp
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Feb 27, 2024
PR #32331: Size comparison from a2d98f8 to 9fc6ade Increases above 0.2%:
Increases (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (2 builds for k32w, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@cjandhyala can you please add the |
shubhamdp
force-pushed
the
esp32_diag_log_crash
branch
from
February 28, 2024 13:24
9fc6ade
to
c68098a
Compare
PR #32331: Size comparison from 355e2b4 to c68098a Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
dhrishi
approved these changes
Feb 28, 2024
Sarthak-Shaha
pushed a commit
to Sarthak-Shaha/connectedhomeip_silabs
that referenced
this pull request
Mar 5, 2024
… requests (project-chip#32331) * [ESP32] Provide core dump summary in response to crash diagnostic log requests. * use esp_core_dump_image_check when core dump size is requested
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
… requests (project-chip#32331) * [ESP32] Provide core dump summary in response to crash diagnostic log requests. * use esp_core_dump_image_check when core dump size is requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only send the core dump summary instead of complete core dump.
This also addresses the after merge comment #32192 (review)