-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Read core dump from flash, for diagnostic crash logs #32192
[ESP32] Read core dump from flash, for diagnostic crash logs #32192
Conversation
PR #32192: Size comparison from 2f2c4f1 to f4e8a06 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
...ples/temperature-measurement-app/esp32/main/include/diagnostic-logs-provider-delegate-impl.h
Outdated
Show resolved
Hide resolved
examples/temperature-measurement-app/esp32/main/diagnostic-logs-provider-delegate-impl.cpp
Show resolved
Hide resolved
PR #32192: Size comparison from 2f2c4f1 to 508ea6c Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@woody-apple @andy31415 Can you please cherry-pick this platform specific change to |
case IntentEnum::kCrashLogs: { | ||
#if defined(CONFIG_ESP_COREDUMP_ENABLE_TO_FLASH) && defined(CONFIG_ESP_COREDUMP_DATA_FORMAT_ELF) | ||
CrashLogContext * logContext = context->Crash.logContext; | ||
size_t dataSize = logContext->crashSize - logContext->readOffset; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires care to ensure readOffset always < crashSize otherwise integer overflow can allow indeterminate read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…-chip#32192) * [ESP32] Read core dump from flash, for diagnostic crash logs * Restyled by clang-format * Restyled by prettier-markdown * add espcoredump to .wordlist * Add some null checks and init the struct members --------- Co-authored-by: Restyled.io <[email protected]>
Send actual core dump as diagnostic crash logs.
Fixes #31727
Tests
Crashed device once and read and decoded the core dump