-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial EVSE device type to matter-devices.xml. Updated energy-… #31753
Merged
mergify
merged 2 commits into
project-chip:master
from
jamesharrow:Add-initial-EVSE-Device-type-and-fix-ZAP-warnings-about-missing-clusters
Feb 4, 2024
Merged
Added initial EVSE device type to matter-devices.xml. Updated energy-… #31753
mergify
merged 2 commits into
project-chip:master
from
jamesharrow:Add-initial-EVSE-Device-type-and-fix-ZAP-warnings-about-missing-clusters
Feb 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…management-app.zap to use the new device type and fixed missing clusters on Root node
PR #31753: Size comparison from 3e8ef2a to 580bec8 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
January 30, 2024 12:50
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
January 30, 2024 12:50
cecille
approved these changes
Jan 30, 2024
examples/energy-management-app/energy-management-common/energy-management-app.zap
Show resolved
Hide resolved
I added it manually because ZAP now spits out lots of Red siren 🚨 symbols if the root node is missing these.In one case the esp32 build wouldn’t build for me until I fixed this.On 30 Jan 2024, at 18:30, C Freeman ***@***.***> wrote:
@cecille approved this pull request.
In examples/energy-management-app/energy-management-common/energy-management-app.zap:
@@ -746,6 +746,266 @@
}
]
},
+ {
+ "name": "Localization Configuration",
were these added manually, or was this a zap addition? ie, do you WANT these clusters, or is this a weird zap side effect?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
jmeg-sfy
approved these changes
Feb 2, 2024
…Device-type-and-fix-ZAP-warnings-about-missing-clusters
PR #31753: Size comparison from 1f3675c to fd4a9c2 Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jamesharrow
deleted the
Add-initial-EVSE-Device-type-and-fix-ZAP-warnings-about-missing-clusters
branch
February 4, 2024 14:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EVSE Device type had been missing, and the energy-management-app ZAP file was therefore generating errors.
Other clusters on Root node were missing and have been added to stop the warnings ZAP is now generating.