Skip to content

Commit

Permalink
Fix build of darwin-framework-tool with progress logging disabled. (#…
Browse files Browse the repository at this point in the history
…26006)

* CustomFlowString is used even if progress logging is disabled.
* The id variable in GetCommissionerNodeIdCommand was unused when progress
  logging was disabled.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Apr 22, 2024
1 parent 091fc9d commit 1235099
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
auto * controller = CurrentCommissioner();
VerifyOrReturnError(nil != controller, CHIP_ERROR_INCORRECT_STATE);

auto id = [controller.controllerNodeId unsignedLongLongValue];
ChipLogProgress(chipTool, "Commissioner Node Id 0x" ChipLogFormatX64, ChipLogValueX64(id));
ChipLogProgress(
chipTool, "Commissioner Node Id 0x" ChipLogFormatX64, ChipLogValueX64(controller.controllerNodeId.unsignedLongLongValue));

SetCommandExitStatus(CHIP_NO_ERROR);
return CHIP_NO_ERROR;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@

namespace {

#if CHIP_PROGRESS_LOGGING

NSString * CustomFlowString(MTRCommissioningFlow flow)
{
switch (flow) {
Expand All @@ -42,8 +40,6 @@
return @"???";
}

#endif // CHIP_PROGRESS_LOGGING

} // namespace

void SetupPayloadParseCommand::LogNSError(const char * logString, NSError * error)
Expand Down

0 comments on commit 1235099

Please sign in to comment.