-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue: #30580 Create initial EVSE cluster for SDK #30581
Conversation
PR #30581: Size comparison from f67cf70 to ed285f5 Increases (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg)
Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg)
|
PR #30581: Size comparison from f67cf70 to 290f3f4 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why we are calling this energy evse rather than just evse cluster?
This was the name agreed in EM TT after allocating cluster IDs with Cam. |
Was hard to diff because https://github.com/csa-data-model/projects/issues/395, but managed it in the end. |
290f3f4
to
d950ad0
Compare
PR #30581: Size comparison from d82ce57 to d950ad0 Increases (17 builds for cc13x4_26x4, cc32xx, k32w, nrfconnect, qpg)
Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
Updated after rebasing to latest master. Added cluster name to Python CHIP-REPL Re-ran regen_all
PR #30581: Size comparison from d82ce57 to 4c4e16c Increases above 0.2%:
Increases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for bl702l, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…oposed upstream in PR# #30581
Issue: #30580 Create initial EVSE cluster for SDK
NOTE this should be compared with the EVSE spec PR 7813
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7813
There have been many changes in the EVSE cluster since 0.7 ballot, such as standardising on new types for power, energy etc.
This relates to PR# https://github.com/project-chip/connectedhomeip/pull/30389/files
NOTE: The XML here was autogen'd from spec with thanks to Hasty who has access to that tool.