Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Zap / Chip DataModelLogger-src.zapt need correcting for EVSE::Events:RFID #30666

Closed
jamesharrow opened this issue Nov 27, 2023 · 1 comment · Fixed by #30692
Closed
Labels
bug Something isn't working needs triage

Comments

@jamesharrow
Copy link
Contributor

Reproduction steps

In PR #30581 a change was made to DataModelLogger-src.zapt to handle the chip-tool compilation issue with EnergyEVSE cluster XML.

../examples/chip-tool/third_party/connectedhomeip/zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp:16028:54: error: 'chip::app::Clusters::EnergyEvse::Events::RFID' has not been declared
16028 |             chip::app::Clusters::EnergyEvse::Events::RFID::DecodableType value;
      |                                                      ^~~~
In file included from ../examples/chip-tool/third_party/connectedhomeip/src/system/SystemLayer.h:33,
                 from ../examples/chip-tool/third_party/connectedhomeip/src/lib/core/CHIPCore.h:30,
                 from ../examples/chip-tool/third_party/connectedhomeip/src/lib/core/Optional.h:29,
                 from ../examples/chip-tool/third_party/connectedhomeip/src/app/ConcreteAttributePath.h:23,
                 from ../examples/chip-tool/third_party/connectedhomeip/zzz_generated/app-common/app-common/zap-generated/cluster-objects.h:26,
                 from ../examples/chip-tool/commands/clusters/DataModelLogger.h:23,
                 from ../examples/chip-tool/third_party/connectedhomeip/zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp:20:
../examples/chip-tool/third_party/connectedhomeip/zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp:16029:70: error: 'value' was not declared in this scope
16029 |             ReturnErrorOnFailure(chip::app::DataModel::Decode(*data, value));

The change made in #30581 made the autogen use:
asUpperCamelCase: https://github.com/project-chip/connectedhomeip/blob/master/examples/chip-tool/templates/logging/DataModelLogger-src.zapt#L23C148-L23C161

However it is believed that this fix should be reverted and a change made to Zap, so it can use:
zapTypeToDecodableClusterObjectType

This issue is to track that change back.

As discussed with @bzbarsky-apple

Bug prevalence

1.3 EnergyEVSE cluster has shown up this bug

GitHub hash of the SDK that was being used

N/A

Platform

core

Platform Version(s)

1.3

Type

Spec Compliance Issue

Anything else?

No response

@bzbarsky-apple
Copy link
Contributor

project-chip/zap#1218 fixes ZAP here to do the right thing.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 28, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 28, 2023
…ctly.

Fixes project-chip#30666

The zap_file_parser.py change fixes broken handling of null default values.
@mergify mergify bot closed this as completed in #30692 Nov 29, 2023
mergify bot pushed a commit that referenced this issue Nov 29, 2023
…ctly. (#30692)

* Update ZAP to fix zapTypeToDecodableClusterObjectType to behave correctly.

Fixes #30666

The zap_file_parser.py change fixes broken handling of null default values.

* Auto-update ZAP files.

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
2 participants