-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add the lit-icd-app to the CI run for the ICD integration tests #30291
Merged
mkardous-silabs
merged 11 commits into
project-chip:master
from
mkardous-silabs:feature/icdm_test
Nov 8, 2023
Merged
[ICD] Add the lit-icd-app to the CI run for the ICD integration tests #30291
mkardous-silabs
merged 11 commits into
project-chip:master
from
mkardous-silabs:feature/icdm_test
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
force-pushed
the
feature/icdm_test
branch
from
November 7, 2023 20:40
380c980
to
ae921e9
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran and
hawk248
November 7, 2023 20:54
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
November 7, 2023 20:54
mkardous-silabs
force-pushed
the
feature/icdm_test
branch
from
November 7, 2023 21:00
c85f649
to
7b20ce3
Compare
jmartinez-silabs
approved these changes
Nov 7, 2023
PR #30291: Size comparison from 2d62ad1 to 7b20ce3 Increases (1 build for psoc6)
Decreases (8 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Nov 8, 2023
tima-q
approved these changes
Nov 8, 2023
PR #30291: Size comparison from 2d62ad1 to 0f3535a Increases above 0.2%:
Increases (16 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (8 builds for esp32, linux, nrfconnect, psoc6)
Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #30291: Size comparison from 2d62ad1 to 7b45c0d Increases above 0.2%:
Increases (27 builds for bl702, bl702l, cc32xx, linux, psoc6, telink)
Decreases (20 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30291: Size comparison from 2d62ad1 to 126958d Increases above 0.2%:
Increases (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (21 builds for bl702l, esp32, linux, nrfconnect, psoc6, telink)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ICD integration tests where initially run on the all-clusters app. Since the ICD tests require the app to be built as an ICD and have the associated ICDM configurations, it was not possible to fully run all the necessary tests on the all-clusters-app.
The lit-icd-app (added in a previous PR) is configured and built as a Long Idle Time ICD which allows us to perform all the integration tests.
fixes #29397