-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Adds changes in build system to support docker image change #30181
Merged
mergify
merged 5 commits into
project-chip:master
from
rosahay-silabs:feature/build-changes-for-docker
Nov 6, 2023
Merged
[Silabs] Adds changes in build system to support docker image change #30181
mergify
merged 5 commits into
project-chip:master
from
rosahay-silabs:feature/build-changes-for-docker
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brosahay
commented
Nov 2, 2023
•
edited
Loading
edited
- Refactor build files to integrate SDK path as variable
- Reduce wiseconnect SDK clone inside of docker image
brosahay
force-pushed
the
feature/build-changes-for-docker
branch
from
November 2, 2023 18:49
b6bf956
to
42a096a
Compare
PR #30181: Size comparison from 71a72ae to 42a096a Full report (26 builds for cc13x4_26x4, cc32xx, cyw30739, k32w, mbed, nrfconnect, psoc6, qpg)
|
brosahay
force-pushed
the
feature/build-changes-for-docker
branch
from
November 2, 2023 19:56
42a096a
to
40a6206
Compare
PR #30181: Size comparison from 94a6f93 to 9613cc9 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
brosahay
changed the title
Adds changes in build system to support docker image change
[Silabs] Adds changes in build system to support docker image change
Nov 3, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13 and
harsha-rajendran
November 3, 2023 05:53
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 3, 2023 05:53
PR #30181: Size comparison from 94a6f93 to 73fc998 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (51 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30181: Size comparison from 94a6f93 to c17ad8c Increases above 0.2%:
Increases (19 builds for mbed, nrfconnect, telink)
Decreases (20 builds for nrfconnect, telink)
Full report (21 builds for mbed, nrfconnect, telink)
|
jmartinez-silabs
approved these changes
Nov 4, 2023
PR #30181: Size comparison from eb2f8f6 to 526d506 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ksperling-apple
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.