Fix YAML tests using value and constraints together. (#13658)

This used to not work because setDefaultResponse would add two entries
with the same name to the response.values list and then
chip_tests_item_response_parameters would just look for the first
entry in the list with the matching name and look for both value and
constraints on it.

The fix is to make setDefaultResponse produce the data structure that
chip_tests_item_response_parameters is expecting.

src/app/zap-templates/common/ClusterTestGeneration.js

@@ -288,19 +288,13 @@ function setDefaultResponse(test)
     throwError(test, errorStr);
   }
 
-  const name     = test.isAttribute ? test.attribute : test.event;
-  const response = test[kResponseName];
-  if (hasResponseValue) {
-    const value = { name, value : response.value, saveAs : response.saveAs };
-    response.values.push(value);
-  }
+  if (hasResponseValueOrConstraints) {
+    const name             = test.isAttribute ? test.attribute : test.event;
+    const response         = test[kResponseName];
+    const responseValue    = hasResponseValue ? { value : response.value } : null;
+    const constraintsValue = hasResponseConstraints ? { constraints : response.constraints } : null;
 
-  if (hasResponseConstraints) {
-    let constraints = { name : name, constraints : response.constraints };
-    if ('saveAs' in response && !hasResponseValue) {
-      constraints.saveAs = response.saveAs;
-    }
-    response.values.push(constraints);
+    response.values.push({ name, saveAs : response.saveAs, ...responseValue, ...constraintsValue });
   }
 
   delete test[kResponseName].value;