-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add LIT ICD reference app for tests and certification #30092
Merged
mkardous-silabs
merged 13 commits into
project-chip:master
from
mkardous-silabs:feature/icd_test_device
Nov 3, 2023
Merged
[ICD] Add LIT ICD reference app for tests and certification #30092
mkardous-silabs
merged 13 commits into
project-chip:master
from
mkardous-silabs:feature/icd_test_device
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
October 30, 2023 14:24
PR #30092: Size comparison from dd920f2 to 725eb2c Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
mkardous-silabs
force-pushed
the
feature/icd_test_device
branch
from
October 30, 2023 17:08
725eb2c
to
12369ec
Compare
PR #30092: Size comparison from 1d28109 to 12369ec Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Oct 31, 2023
bzbarsky-apple
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok now, though not having any application endpoints is a bit odd.
jmartinez-silabs
approved these changes
Nov 2, 2023
mkardous-silabs
force-pushed
the
feature/icd_test_device
branch
from
November 2, 2023 13:56
1bbedbd
to
fdd3851
Compare
PR #30092: Size comparison from bba25c5 to fdd3851 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
force-pushed
the
feature/icd_test_device
branch
from
November 3, 2023 18:38
4c18d60
to
d024c03
Compare
PR #30092: Size comparison from 754a938 to d024c03 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a reference example app for the LIT ICD device type.
This will allow us to run intergration tests with an example that implements the LIT ICD requirements.
PR only adds the example to the build steps, test will be added in a follow up PR.
partially fixes #29397